ci: validate app-store catalogue entries on PR#259
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+12
to
+33
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 # need the base ref for the downgrade check | ||
|
|
||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: "1.25" | ||
|
|
||
| - name: Extract base catalogue (for downgrade check) | ||
| run: | | ||
| git show "origin/${{ github.base_ref }}:catalogue/catalogue.json" > /tmp/base-catalogue.json 2>/dev/null || echo '{"apps":[]}' > /tmp/base-catalogue.json | ||
|
|
||
| - name: Build verifier | ||
| run: | | ||
| git clone --depth 1 https://github.com/pilot-protocol/app-template /tmp/app-template | ||
| (cd /tmp/app-template && go build -o /tmp/pilot-app ./cmd/pilot-app) | ||
|
|
||
| - name: Verify catalogue entries | ||
| run: | | ||
| PILOT_CATALOGUE_BASE=/tmp/base-catalogue.json /tmp/pilot-app verify catalogue/catalogue.json |
Adds a catalogue-validate workflow that runs the app-template verifier on any PR touching catalogue/catalogue.json (bundle sha, manifest validity + signature, <ns>.help discovery, id/version, downgrade guard), plus a reviewer PR template for the human half of the review gate.
This is a supply-chain trust gate; building the verifier from an unpinned upstream HEAD would let an app-template change flow straight into the gate. Pin to the released v0.1.0 tag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
TeoSlayer
force-pushed
the
catalogue/add-validation-ci
branch
from
e7b3753 to
9056190
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gates every
catalogue/catalogue.jsonchange with the app-store review gate (SPEC §7.1): builds thepilot-protocol/app-templateverifier and checks each entry — bundle reachable,bundle_sha256matches, manifest validates + signature verifies, binary sha pinned, a<ns>.helpmethod is exposed, id/version consistent, no version downgrade. Adds a reviewer PR template for the human checklist (§7.2).Part of standardizing app publishing; full flow in
pilot-protocol/app-templatedocs/APP-PUBLISHING-SPEC.md.